Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Amazon Ads: migrate source to YamlDeclarativeSource with custom check_connection #35481

Merged
merged 9 commits into from
Mar 6, 2024
Merged

✨Source Amazon Ads: migrate source to YamlDeclarativeSource with custom check_connection #35481

merged 9 commits into from
Mar 6, 2024

Conversation

askarpets
Copy link
Contributor

@askarpets askarpets commented Feb 21, 2024 •
edited
Loading

What

Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/2863

How

  • Added DeclarativeSourceAdapter, which is inherited from YamlDeclarativeSource and delegates methods check and streams to the SourceAmazonAds class
  • Replaced SourceAmazonAds with DeclarativeSourceAdapter in run.py
  • Moved spec to manifest.yaml and deleted spec.yaml

Recommended reading order

  1. declarative_source_adapter.py
  2. manifest.yaml
  3. run.py

🚨 User Impact 🚨

No breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@askarpets askarpets self-assigned this Feb 21, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 0:01am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited by askarpets
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 22, 2024
@askarpets askarpets marked this pull request as ready for review February 22, 2024 12:55
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 22, 2024 12:56
girarda
girarda approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just one request for a comment :shipit:

...te-integrations/connectors/source-amazon-ads/source_amazon_ads/declarative_source_adapter.py Show resolved Hide resolved
@askarpets
Copy link
Contributor Author

askarpets commented Mar 5, 2024 •
edited
Loading

Testing summary:

  • spec: outputs identical
  • check:
    • success: outputs identical
    • failure: outputs identical (except failed rows paths)
  • discover: outputs identical (except the order of properties in columns with type of 'object')
  • read: outputs identical

@girarda could you please confirm this can be merged?

@girarda
Copy link
Contributor

girarda commented Mar 6, 2024

:shipit: @askarpets !

@askarpets askarpets merged commit dee240a into master Mar 6, 2024
30 of 31 checks passed
@askarpets askarpets deleted the source-amazon-ads-migrate-to-low-code branch March 6, 2024 09:57
xiaohansong pushed a commit that referenced this pull request Mar 7, 2024
@xiaohansong
✨Source Amazon Ads: migrate source to YamlDeclarativeSource with cu…
a75d336 
…stom `check_connection` (#35481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

@bazarnov bazarnov Awaiting requested review from bazarnov

@artem1205 artem1205 Awaiting requested review from artem1205

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

Assignees

@askarpets askarpets

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@askarpets @girarda @octavia-squidington-iii